Agent skill · writing content · metabase
e2e-test-review
Review Cypress E2E spec files for Metabase conventions, common gotchas, and flakiness/performance issues. Use when reviewing pull requests or diffs containing Cypress spec files in e2e/test/scenarios/.
Why this skill is useful
Provides a detailed checklist and review process for Cypress E2E tests that ensures adherence to Metabase conventions and identifies potential issues.
What it needs
About 11k tokens when loaded. Last updated 2026-08-07. 48,568 stars on the source repository.
What this skill does
E2E Test Review Skill @./../shared/cypress-conventions.md Review mode detection Before starting, determine which mode to use: 1. PR review mode — if mcpgithubcreatependingpullrequestreview is available, post issues as one cohesive pending review. 2. Local review mode — if not, output a numbered list in the conversation. Review process 1. Detect mode. 2. Read the changed spec end-to-end first to understand intent. Don't review line-by-line cold. 3. (Conditional) If after reading the spec a specific assertion or selector is ambiguous — you can't tell if it's the right anchor, or whether the test actually verifies what its title claims — briefly grep the related component for the test ID / role / text. Don't read components by default. Only do this when there's a real signal of confusion in the spec. 4. Scan against the checklist + pattern table below. 5. Number all issues sequentially. Skip nits — only flag what's worth fixing. 6. Always finish with the honest e2e-vs-unit breakdown (see the section of that name below). It's part of every report, not an optional add-on. When to hand off instead of review If the spec references an issue (metabase#NNNNN) and the user wants to fix flakiness or assess whether the test still reproduces the original bug, that's outside the review skill's scope. Point them at the dedicated flake-fixing workflow, which knows to fetch the issue and the resolving PR's diff. The review skill stays focused on "is this test well-written and conformant" — it doesn't fetch external issue context by default. Review checklist The checklist mirrors the order of the conventions file. Items marked (lint) are also caught by ESLint — flag only when you see them slip through (helper-wrapped, lint-disabled, etc.). …
How to use it
Reference it in AdaL, Claude Code, Cursor or any coding agent — nothing to install:
@skills metabase/e2e-test-review